Skip to content

Conversation

@HarelM
Copy link
Collaborator

@HarelM HarelM commented Nov 20, 2025

Launch Checklist

The problem is that the editor at the end of the layer editor view is forcing some scrolling due to a different bug that was solved.

The previous fix was in oder to solve issues in the code editor which has all the style in it, and a search-and-replace operation is used to change the content, so there was a need to introduce the previous fix.
The current solution is to scroll the view only for the code editor using a react prop, which is false by default.

  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Write tests for all new functionality.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.12%. Comparing base (74a21e1) to head (846bb19).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1525      +/-   ##
==========================================
+ Coverage   69.70%   71.12%   +1.42%     
==========================================
  Files         102      102              
  Lines        6357     6964     +607     
  Branches     1869     2097     +228     
==========================================
+ Hits         4431     4953     +522     
- Misses       1923     2008      +85     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HarelM HarelM marked this pull request as ready for review December 3, 2025 11:14
@HarelM HarelM requested review from birkskyum and louwers December 3, 2025 11:16
@HarelM HarelM enabled auto-merge (squash) December 3, 2025 11:20
@HarelM HarelM merged commit c168e65 into main Dec 3, 2025
11 checks passed
@HarelM HarelM deleted the 1524-fix-scroll branch December 3, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Layer drawer scrolls/jumps around when editing properties

4 participants